feat: add defaultExpanded and renderStrategy props to ReleasePlanMilestone#11639
Open
thomasheartman wants to merge 1 commit intomainfrom
Open
feat: add defaultExpanded and renderStrategy props to ReleasePlanMilestone#11639thomasheartman wants to merge 1 commit intomainfrom
thomasheartman wants to merge 1 commit intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
thomasheartman commented Mar 17, 2026
| }} | ||
| /> | ||
| )} | ||
| {renderStrategy?.(strategy, index) ?? |
Contributor Author
There was a problem hiding this comment.
I don't know about this. I'm not loving that implementation, to be honest. Curious to hear other suggestions.
Contributor Author
There was a problem hiding this comment.
It might also just feel weird because it's followed by a flag-gated component.
thomasheartman added 🤖 all-ai thomasheartman force-pushed the heart/milestone-render-strategy-props branch from 4729bf0 to 07642c7 Compare thomasheartman force-pushed the heart/refactor-apply-release-plan-changes branch from 8efcb75 to 5d9a59f Compare thomasheartman force-pushed the heart/milestone-render-strategy-props branch 2 times, most recently from 509a700 to 8f1ca8d Compare thomasheartman force-pushed the heart/refactor-apply-release-plan-changes branch 2 times, most recently from 694aaa2 to fbb52a5 Compare thomasheartman force-pushed the heart/milestone-render-strategy-props branch 2 times, most recently from 5ae6b38 to 9942c4f Compare thomasheartman force-pushed the heart/refactor-apply-release-plan-changes branch from fbb52a5 to 57db459 Compare Base automatically changed from heart/refactor-apply-release-plan-changes to main March 19, 2026 10:38
…stone Add generic extension points to support custom strategy rendering and auto-expanding milestones. Extract EditControls in draggable item.
thomasheartman force-pushed the heart/milestone-render-strategy-props branch from 9942c4f to dbd487a Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add generic extension points to support custom strategy rendering and auto-expanding milestones.