use releasePlanSnapshot prop when available#11652
Open
thomasheartman wants to merge 1 commit intoheart/consolidate-milestone-strategy-crfrom
Open
use releasePlanSnapshot prop when available#11652thomasheartman wants to merge 1 commit intoheart/consolidate-milestone-strategy-crfrom
thomasheartman wants to merge 1 commit intoheart/consolidate-milestone-strategy-crfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
thomasheartman force-pushed the heart/push-pkrqokxmkloq branch from 13ebf8d to 982c0aa Compare 
thomasheartman force-pushed the heart/consolidate-milestone-strategy-cr branch from a0d6f4e to 9fbefdd Compare thomasheartman force-pushed the heart/push-pkrqokxmkloq branch from 982c0aa to 80cf471 Compare 
dharmadeveloper108 approved these changes Mar 20, 2026
Contributor
dharmadeveloper108 left a comment
dharmadeveloper108 left a comment There was a problem hiding this comment.
looks great to me!!
github-project-automation bot moved this from In Progress to Approved PRs in Issues and PRs This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
releasePlanSnapshotproperty to render the diff of the release plan as it was at the moment of CR closure (application/rejection/cancellation). Also, strip this property from places where it'd show up in the diff.This solves the problem of applied CRs with milestone strategy updates showing the current state of the release plan instead of the state when the CR was applied.
For instance, these two views show the same PR. Left is with these changes (and the accompanying enterprise updates), right is without them. The CR changed the rollout for the top two milestones, but didn't touch the third one (which was at 100%). After rejecting, I went and manually changed the rollout for milestone 3 to 36. Notice that the right one now erroneously shows 36, while the left one shows the expected 100.