Replace float transmutes with to/from_bits#140
Open
197g wants to merge 1 commit intoVoidStarKat:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires an MSRV bump to
1.83so if I understand policy correctly this would go in a2.8release. In any case this PR ca be left around and delayed until then. The last change was a good year back; since then Rust marked a whole bunch of intrinsics assafe(1.87 with further cpu features etc. added up to 1.91). If desirable, a little bit of house keeping to make use of that may motivate a release with a more current rust-version anyways?