Sync using faster storex create op - rawCreateObjects#5
Open
cdharris wants to merge 1 commit intoWorldBrain:developfrom
Open
Sync using faster storex create op - rawCreateObjects#5cdharris wants to merge 1 commit intoWorldBrain:developfrom
cdharris wants to merge 1 commit intoWorldBrain:developfrom
Conversation
Contributor Author
Member
| @ShishKabab what about this PR? Is that still valid or should we close it? |
Member
| This does need to be integrated at some point, yes. Maybe it could provide a nice speedup, but we'd need to test it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the storex operation
rawCreateObjectsto sync rather than iterate through each sync batch usingcreateObject.