Skip to content

Add "enableDoubleFindToReplace" option#5346

Open
nunziotocci wants to merge 4 commits intoajaxorg:masterfrom
nunziotocci:master
Open

Add "enableDoubleFindToReplace" option#5346
nunziotocci wants to merge 4 commits intoajaxorg:masterfrom
nunziotocci:master

Conversation

@nunziotocci
Copy link
Copy Markdown

Issue #, if available:
Brings back the behavior that #2653 complained about behind an option.

Description of changes:
Add "enableDoubleFindToReplace" option. This allows you to press Ctrl-F while the find window is open to toggle the replace option. I'm used to it, and so are the people at my company.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@InspiredGuy
Copy link
Copy Markdown
Contributor

Thank you for the contribution. Could you please add the new option to the types declaration in ace.d.ts, add a test for the new option, and expose the option in the kitchen sink? Please refer to #5233 as an example for those

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.42%. Comparing base (7a6b83e) to head (06a294f).
⚠️ Report is 423 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #5346 +/- ## ========================================== + Coverage 87.41% 87.42% +0.01%  ========================================== Files 574 574 Lines 45613 45613 Branches 6935 6935 ========================================== + Hits 39873 39878 +5  + Misses 5740 5735 -5 
Flag Coverage Δ
unittests 87.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@github-actions
Copy link
Copy Markdown

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@github-actions
Copy link
Copy Markdown

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@nunziotocci
Copy link
Copy Markdown
Author

I have added it to ace.d.ts via ace-internal.d.ts and npm run update-types. I also added it to the Kitchen Sink.

I don't see any tests for ext/searchbox. How might I go about adding one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants