Skip to content

Add penalty on case mismatch to completion filter#5626

Open
jonpyt wants to merge 13 commits intoajaxorg:masterfrom
jonpyt:master
Open

Add penalty on case mismatch to completion filter#5626
jonpyt wants to merge 13 commits intoajaxorg:masterfrom
jonpyt:master

Conversation

@jonpyt
Copy link
Copy Markdown
Contributor

@jonpyt jonpyt commented Aug 17, 2024

Issue #, if available: N/A

I read through the code of the filterCompletions method and saw a TODO comment asking to implement a penalty on case mismatch. Not entirely sure what would be a good value for the penalty, but I went with 3 for each character and it works well enough.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (0192880) to head (3053e0d).
Report is 125 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #5626 +/- ## ======================================= Coverage 86.91% 86.92% ======================================= Files 594 594 Lines 43222 43246 +24 Branches 7155 7156 +1 ======================================= + Hits 37568 37593 +25  + Misses 5654 5653 -1 
Flag Coverage Δ
unittests 86.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant