Draft
Conversation
Author
| @akoreman Hey! Could you help me get set up with a suitable review buddy? This is a first draft, but I'm happy and going to dogfood it in (less critical parts of) production. Anything that comes up during the test phase, will be amended by my own initiative. It would be nice to have a preliminary review on the patterns and implementation choices as I was mildly confused by the codbase and how to get a handle on it, so I basically did educated guessing and copy pasting and a lot of long iterations. I'd hope with some expert eyes on it, the low hanging fruits for improvement can be taken already. |
1 task
blaggacao commented Sep 8, 2024
Comment on lines +38 to +40
| if (this.mayBeJinjaVariable(token)) { | ||
| return this.getVariableCompletions(state, session, pos, prefix); | ||
| } |
Author
There was a problem hiding this comment.
Note to self: remove. Or better, still: detect variables of for loops or set directives.
But how?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: