Skip to content

use new css api when available#5646

Open
nightwing wants to merge 2 commits intoajaxorg:masterfrom
nightwing:csp
Open

use new css api when available#5646
nightwing wants to merge 2 commits intoajaxorg:masterfrom
nightwing:csp

Conversation

@nightwing
Copy link
Copy Markdown
Member

using adoptedStylesheets allows to save memory when using ace in shadow dom, and also removes the need for using separate stylesheets in cases when unsafe-inline for css is disabled but data for images is allowed.

@nightwing nightwing force-pushed the csp branch 2 times, most recently from 481fa09 to 3e8792e Compare September 28, 2024 08:24
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.96%. Comparing base (560f5d3) to head (3e8792e).
Report is 112 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/dom.js 60.00% 6 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #5646 +/- ## ========================================== - Coverage 86.97% 86.96% -0.01%  ========================================== Files 594 594 Lines 43395 43410 +15 Branches 7170 7173 +3 ========================================== + Hits 37742 37751 +9  - Misses 5653 5659 +6 
Flag Coverage Δ
unittests 86.96% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
style-src 'self' ;
img-src 'self' ;
script-src 'self' 'nonce-bootstrap-script';
script-src 'self' 'nonce-bootstrap-script' https://mkslanc.github.io;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to add this on this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants