Skip to content

Updated the CSS Syntax Highlighter#5676

Open
TimChinye wants to merge 1 commit intoajaxorg:masterfrom
TimChinye:patch-2
Open

Updated the CSS Syntax Highlighter#5676
TimChinye wants to merge 1 commit intoajaxorg:masterfrom
TimChinye:patch-2

Conversation

@TimChinye
Copy link
Copy Markdown

@TimChinye TimChinye commented Nov 15, 2024

Updated the mode-css.js file to the latest CSS specifications, using MDN provided information and Ace Linters (As of May 29).

Issue #, if available: #5559

Description of changes: Updated the mode-css.js file to latest CSS specifications, using MDN provided information and Ace Linters.

Additional Info:

  • Ace Linters supports Non-standard and Deprecated code, but not Experimental - this CSS Mode complies with that.
  • khz and hz units are no longer supported, as they're technically experimental (as in - they have not use "yet"), gd unit has been removed as it's seemingly a myth. Was mentioned in a single version of a CSS specification with zero information to go along with it, and removed within a year.
  • Still does not take into consideration the new CSS Nesting.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Original Issue: ajaxorg/ace-builds#264 (comment)

Pull Request Checklist:

Updated the mode-css.js file to the latest CSS specifications, using MDN provided information and [Ace Linters](https://github.com/mkslanc/ace-linters) (As of May 29).
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (6dfb903) to head (a48a550).
Report is 98 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #5676 +/- ## ======================================= Coverage 87.01% 87.01% ======================================= Files 598 598 Lines 43680 43680 Branches 7204 7204 ======================================= Hits 38009 38009 Misses 5671 5671 
Flag Coverage Δ
unittests 87.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant