Add snippet support for LaTeX and custom macro completer.#5840
Open
JeanCASPAR wants to merge 1 commit intoajaxorg:masterfrom
Open
Add snippet support for LaTeX and custom macro completer.#5840JeanCASPAR wants to merge 1 commit intoajaxorg:masterfrom
JeanCASPAR wants to merge 1 commit intoajaxorg:masterfrom
Conversation
JeanCASPAR force-pushed the latex-completer branch from 24992c1 to 5829f78 Compare 
| One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
JeanCASPAR force-pushed the latex-completer branch from 5829f78 to 8cd00b9 Compare | One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
The snippets are copied from the snippets for TeX. The current keywordCompleter for LaTeX is unused because the highlight rules do not give a list of keywords, but color every LaTeX macro, so the completer cannot use the rules to provide completion. This macro completer is inspired by the text completer, but autocomplete only macros (the current text completer do not consider \ to be a part of a word). The interface of Completer is changed so that the keywordCompleter can forward the triggerCharacters and identifiersRegexps of `session.$mode.completer`.
JeanCASPAR force-pushed the latex-completer branch from 8cd00b9 to 9f9af4a Compare | One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Contributor Author
| Also, the current mechanism of identifierRegexps is quite unsatisfactory : as we pass a macro that test every character separately, is it impossible for the function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fix #5834.
Description of changes:
The snippets are copied from the snippets for TeX. The default keywordCompleter is unused in LaTeX mode because the highlight rules do not give a list of keywords, but color every LaTeX macro, so the completer cannot use the rules to provide completion. This macro completer is inspired from the text completer, but complete only macros (the current text completer do not consider \ to be a part of a word).
The interface of Completer is changed so that the keywordCompleter can forward the triggerCharacters and identifiersRegexps of
session.$mode.completer. I don't know if this change is backward compatible, but I do not see any other way to achieve this goal. Maybe we can provide a better way for a mode to propose a completer than using keywordCompleter ?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: