refactor: avoid passing too much stuff in redux#132
Draft
cheng-kang wants to merge 4 commits intomasterfrom
Draft
refactor: avoid passing too much stuff in redux#132cheng-kang wants to merge 4 commits intomasterfrom
cheng-kang wants to merge 4 commits intomasterfrom
Conversation
Member
这个重写会不会有很多坑,,其实这个我都想去掉,,直接数据放表里,,免得去合并这块数据,,当时是为了结剩点免费表的空间才写的,,你觉得呢?? |
Collaborator Author
确实花了很长时间才重写完,我测试了所有用到 setDataSourceValue 和 getDataSourceValue 的地方,应该和之前的一样没什么问题。等这个 PR 完全准备好了,还得麻烦你再测试一下。 直接放表里挺好的,可以记录在 roadmap 里面之后做。我现在主要是在现有的基础上调整一下,不修改任何原本有的行为,方便其他方面的开发和调试。 |
Member
| @cheng-kang 我后面可能在这的维护时间比较少了,,你看可以,你就自已合吧,,先扔上去,,有 bug 再修呗。。。 |
Member
| editor-list 我给你加权限, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题描述
目前由于在 redux 里面存了 dom 元素等导致 redux dev tool 崩溃。这个 PR 的目的是从 redux 中移除这些不必要的内容,仅传输和存储最少的、必要的信息,比如 dom 元素的 id 或者 data-id。
计划