Skip to content

feat: Add support for Spark ToDegrees and ToRadians math expressions#3786

Open
rafafrdz wants to merge 1 commit intoapache:mainfrom
rafafrdz:feat/add-degrees-radians-functions
Open

feat: Add support for Spark ToDegrees and ToRadians math expressions#3786
rafafrdz wants to merge 1 commit intoapache:mainfrom
rafafrdz:feat/add-degrees-radians-functions

Conversation

@rafafrdz
Copy link
Copy Markdown
Contributor

@rafafrdz rafafrdz commented Mar 25, 2026 •
edited
Loading

Summary

  • Add support for Spark's ToDegrees and ToRadians angle conversion expressions
  • Delegates to DataFusion's built-in degrees and radians functions via CometScalarFunction
  • No native Rust code needed — DataFusion's function registry handles execution
  • SQL tests added covering standard angle values, NULL, and NaN

Test plan

  • SQL tests added: degrees.sql, radians.sql
  • CometSqlFileTestSuite verified — all 4 tests pass (2 per function × dictionary=false/true)

Related to #2084
@rafafrdz
feat: Add support for Spark ToDegrees and ToRadians math expressions
53e30ef 
Add angle conversion functions by delegating to DataFusion's built-in degrees and radians implementations via CometScalarFunction. Includes SQL tests for column and literal arguments with edge cases.
@rafafrdz rafafrdz force-pushed the feat/add-degrees-radians-functions branch from ee3865c to 53e30ef Compare March 25, 2026 06:25
@rafafrdz rafafrdz marked this pull request as ready for review March 25, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@rafafrdz