Open
Conversation
…ce epoch from timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3125
Rationale for this change
Comet previously did not support the Spark
hoursexpression (a V2 partition transform).Queries using the
hoursfunction for partitioning would fall back to Spark's JVM execution instead of running natively on DataFusion. By adding native support for this expression, we allow more Spark workloads (especially those partitioned by hourly intervals) to benefit from Comet's native acceleration.What changes are included in this PR?
This change adds end-to-end native support for the
hourspartition transform. SinceHoursis aPartitionTransformExpression(and not aTimeZoneAwareExpression), the timezone is injected from the session configuration during the planning phase.The native implementation uses Arrow's
unaryandtry_unarykernels for efficient vectorized computation, and correctly handles pre-epoch (negative) timestamps using Euclidean floor division (div_euclid). It distinctly handles bothTimestampType(applies timezone offsets) andTimestampNTZType(direct wall-clock computation).expr.proto: AddedHoursTransformmessage definition to pass the child expression and session timezone.datetime.scala: AddedCometHoursserde handler to intercept the SparkHoursexpression and read the timezone fromSQLConf.QueryPlanSerde.scala: Registered theCometHourshandler in the temporal expressions map.hours.rs: AddedSparkHoursTransformUDF using efficient Arrow kernels.temporal.rs&expression_registry.rs: Registered the native Builder for the new expression.How are these changes tested?
Added comprehensive evaluation in both Rust and Scala:
hours.rscovering:TimestampNTZType(ensuring it ignores timezone offsets)cargo test -p datafusion-comet-spark-expr -- datetime_funcs::hours