Skip to content

fix: Handle exceptions in pre-reboot event listeners via return_exceptions#843

Merged
vdusek merged 2 commits intomasterfrom
fix/reboot-gather-return-exceptions
Mar 27, 2026
Merged

fix: Handle exceptions in pre-reboot event listeners via return_exceptions#843
vdusek merged 2 commits intomasterfrom
fix/reboot-gather-return-exceptions

Conversation

@vdusek
Copy link
Copy Markdown
Contributor

@vdusek vdusek commented Mar 26, 2026

Summary

  • Add return_exceptions=True to asyncio.gather in Actor.reboot() so a single failing listener no longer prevents others from persisting state
  • Log any listener exceptions via self.log.exception

Test plan

  • All 182 actor unit tests pass
  • Ruff lint clean

🤖 Generated with Claude Code

…ptions` Use `return_exceptions=True` in `asyncio.gather` during Actor reboot so that a failing listener does not prevent other listeners from persisting state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 26, 2026
@vdusek vdusek self-assigned this Mar 26, 2026
@vdusek vdusek requested a review from Pijukatel March 26, 2026 16:23
@github-actions github-actions bot added this to the 137th sprint - Tooling team milestone Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (1610d0d) to head (0d154ca).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #843 +/- ## ========================================== + Coverage 86.40% 86.64% +0.23%  ========================================== Files 48 48 Lines 2906 2920 +14 ========================================== + Hits 2511 2530 +19  + Misses 395 390 -5 
Flag Coverage Δ
e2e 37.87% <0.00%> (-0.19%) ⬇️
integration 59.28% <0.00%> (-0.19%) ⬇️
unit 74.69% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Copy link
Copy Markdown
Contributor

@Pijukatel Pijukatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to confirm it behaves as expected

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Mar 27, 2026
@vdusek vdusek merged commit ed13597 into master Mar 27, 2026
31 checks passed
@vdusek vdusek deleted the fix/reboot-gather-return-exceptions branch March 27, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

3 participants