fix: handle DST correctly in shift() method for absolute time units#1241
Draft
atulk-code wants to merge 1 commit intoarrow-py:masterfrom
Draft
fix: handle DST correctly in shift() method for absolute time units#1241atulk-code wants to merge 1 commit intoarrow-py:masterfrom
atulk-code wants to merge 1 commit intoarrow-py:masterfrom
Conversation
This fixes issue arrow-py#1209 where shift(hours=X) would only add wall-clock hours instead of actual elapsed hours when crossing a DST boundary. The fix changes the shift() method to: 1. Separate absolute time units (hours, minutes, seconds, microseconds) from calendar units (years, months, weeks, days) 2. Apply calendar shifts using relativedelta (as before) 3. Apply absolute time shifts by converting to UTC first, adding the timedelta, then converting back to the original timezone This ensures that shift(hours=10) adds exactly 10 real hours (36000 seconds) even when crossing a DST spring-forward or fall-back boundary. Updated tests to reflect the new actual-elapsed-time semantics and added a regression test specifically for issue arrow-py#1209.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #1241 +/- ## ========================================== Coverage ? 100.00% ========================================== Files ? 10 Lines ? 2325 Branches ? 361 ========================================== Hits ? 2325 Misses ? 0 Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #1209 where shift(hours=X) would only add wall-clock hours instead of actual elapsed hours when crossing a DST boundary.
The fix changes the shift() method to:
This ensures that shift(hours=10) adds exactly 10 real hours (36000 seconds) even when crossing a DST spring-forward or fall-back boundary.
Updated tests to reflect the new actual-elapsed-time semantics and added a regression test specifically for issue #1209.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes