Fix Italian locale plural seconds timeframe#1249
Open
bysiber wants to merge 1 commit intoarrow-py:masterfrom
Open
Fix Italian locale plural seconds timeframe#1249bysiber wants to merge 1 commit intoarrow-py:masterfrom
bysiber wants to merge 1 commit intoarrow-py:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #1249 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 2315 2315 Branches 358 358 ========================================= Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
The "seconds" timeframe used "{0} qualche secondo" which produces nonsensical output like "15 qualche secondo fa" (literally "15 some second ago"). "qualche secondo" means "a few seconds" and is appropriate as a standalone phrase, not with a numeric prefix. Change to "{0} secondi" which is the correct Italian plural, producing natural output like "15 secondi fa" ("15 seconds ago"). 
bysiber force-pushed the fix/italian-locale-seconds-plural branch from e124c43 to b248b54 Compare 
| return humanized | ||
| | ||
| | ||
| class ItalianLocale(Locale): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Italian locale's
"seconds"timeframe to use the correct plural form.Problem
The
"seconds"timeframe inItalianLocaleis:"qualche secondo" means "a few seconds" / "some seconds" in Italian. When the
{0}placeholder is substituted with a number, the output is grammatically wrong:Other timeframes in the same locale use correct plural forms:
"minutes": "{0} minuti"✓"hours": "{0} ore"✓"days": "{0} giorni"✓Fix
Change to
"{0} secondi"which is the standard Italian plural: