Skip to content

ci: bump golangci-lint to v2.11 for Go 1.26 support#287

Merged
dtnyn merged 2 commits intoatlassian:masterfrom
FocalChord:lint
Mar 24, 2026
Merged

ci: bump golangci-lint to v2.11 for Go 1.26 support#287
dtnyn merged 2 commits intoatlassian:masterfrom
FocalChord:lint

Conversation

@FocalChord
Copy link
Contributor

@FocalChord FocalChord commented Mar 12, 2026

Problem

The golangci-lint CI job is broken on master. The runner gets killed after ~4.5 minutes with no lint output.

Root Cause

The workflow uses go-version: stable which recently floated from Go 1.25 to 1.26. This did two things:

  1. Cache invalidation. The Go cache key includes the Go version, so the bump invalidated all cached build artifacts. The repo also had 3 months of inactivity so the caches had already expired (GitHub expires them after 7 days).

  2. golangci-lint v2.0.2 doesn't support Go 1.26. The [go1.26 support PR](go1.26 support golangci/golangci-lint#6271) was merged after v2.0.2. Without it, go/packages.Load() on a cold build has pathological memory usage that OOMs the 16GB runner before linting even starts.

Fix

Bump golangci-lint from v2.0 to v2.11 which includes Go 1.26 support. Once the first run passes and saves a warm cache, future runs will be fast again.


Rovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.

@FocalChord FocalChord changed the title test: prove golangci-lint CI is broken on master test: golangci-lint CI is broken on master Mar 12, 2026
@FocalChord FocalChord changed the title test: golangci-lint CI is broken on master ci: bump golangci-lint to v2.11 for Go 1.26 support Mar 12, 2026
@FocalChord FocalChord requested a review from awprice March 12, 2026 23:02
@aqasimi aqasimi self-requested a review March 13, 2026 02:21
@dtnyn dtnyn merged commit 043bb1b into atlassian:master Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants