ci: bump golangci-lint to v2.11 for Go 1.26 support#287
Merged
dtnyn merged 2 commits intoatlassian:masterfrom Mar 24, 2026
Merged
ci: bump golangci-lint to v2.11 for Go 1.26 support#287dtnyn merged 2 commits intoatlassian:masterfrom
dtnyn merged 2 commits intoatlassian:masterfrom
Conversation
aqasimi approved these changes Mar 13, 2026
dtnyn approved these changes Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The golangci-lint CI job is broken on master. The runner gets killed after ~4.5 minutes with no lint output.
Root Cause
The workflow uses
go-version: stablewhich recently floated from Go 1.25 to 1.26. This did two things:Cache invalidation. The Go cache key includes the Go version, so the bump invalidated all cached build artifacts. The repo also had 3 months of inactivity so the caches had already expired (GitHub expires them after 7 days).
golangci-lint v2.0.2 doesn't support Go 1.26. The [go1.26 support PR](go1.26 support golangci/golangci-lint#6271) was merged after v2.0.2. Without it,
go/packages.Load()on a cold build has pathological memory usage that OOMs the 16GB runner before linting even starts.Fix
Bump golangci-lint from v2.0 to v2.11 which includes Go 1.26 support. Once the first run passes and saves a warm cache, future runs will be fast again.
Rovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.