fix: persist hostname-override flag to context#630
Open
ivanauth wants to merge 1 commit intoauthzed:mainfrom
Open
fix: persist hostname-override flag to context#630ivanauth wants to merge 1 commit intoauthzed:mainfrom
ivanauth wants to merge 1 commit intoauthzed:mainfrom
Conversation
The --hostname-override flag was not persisted when setting a context, requiring users to pass it on every command. This adds hostname-override to the Token struct and saves it alongside other TLS-related flags like --insecure and --no-verify-ca during `zed context set`. Subcommands now read hostname-override from the stored context, with CLI flags still taking precedence when explicitly provided. Signed-off-by: ivanauth <ivan@authzed.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #630 +/- ## ========================================== - Coverage 41.72% 41.70% -0.02% ========================================== Files 38 38 Lines 6131 6138 +7 ========================================== + Hits 2558 2560 +2 - Misses 3317 3321 +4 - Partials 256 257 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
Persists
--hostname-overrideto zed context storage, matching the existing pattern for--insecureand--no-verify-ca. CLI flag still overrides stored value when explicitly set.