SnsMessageManager Impl#6804
Open
dagnir wants to merge 4 commits intofeature/master/sns-message-managerfrom
Open
SnsMessageManager Impl#6804dagnir wants to merge 4 commits intofeature/master/sns-message-managerfrom
dagnir wants to merge 4 commits intofeature/master/sns-message-managerfrom
Conversation
Provides an implementation of the SnsMessageManager. This mostly just ties all the other classes implemented in previous PRs related to the message manager.
dagnir commented Mar 18, 2026
| /** | ||
| * Utility to load the default HTTP client factory and create an instance of {@link SdkHttpClient}. | ||
| */ | ||
| @SdkInternalApi |
Contributor Author
There was a problem hiding this comment.
We'll need to discuss this change, but hopefully not contentious. I didn't want to move it out of the internal package as that would be a breaking change.
Contributor Author
There was a problem hiding this comment.
Change discussed with the team, and there are no concerns wit this. 3415f9b allowlists this so the arch tests pass.
dagnir commented Mar 18, 2026
| </dependency> | ||
| <dependency> | ||
| <groupId>software.amazon.awssdk</groupId> | ||
| <artifactId>apache5-client</artifactId> |
Contributor Author
There was a problem hiding this comment.
This more or less means we should block this until #6732 is merged
RanVaknin requested changes Mar 24, 2026
...c/main/java/software/amazon/awssdk/messagemanager/sns/internal/DefaultSnsMessageManager.java Show resolved Hide resolved
...est/java/software/amazon/awssdk/messagemanager/sns/internal/CertificateUrlValidatorTest.java Show resolved Hide resolved
...c/main/java/software/amazon/awssdk/messagemanager/sns/internal/DefaultSnsMessageManager.java Show resolved Hide resolved
RanVaknin approved these changes Mar 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License