Fix directory path for set-bridge-partner-threshold task#647
Open
pineapplepeak wants to merge 1 commit intobase:mainfrom
Open
Fix directory path for set-bridge-partner-threshold task#647pineapplepeak wants to merge 1 commit intobase:mainfrom
set-bridge-partner-threshold task#647pineapplepeak wants to merge 1 commit intobase:mainfrom
Conversation
In the current Makefile, the `SET_BASE_BRIDGE_PARTNER_THRESHOLD_DIR` variable pointed to the `...-pause-bridge-base directory`, which resulted in the creation of a folder with an incorrect name when the `make setup-bridge-partner-threshold` command was executed. Fix: The directory suffix has been changed to `-set-bridge-partner-threshold` so that the make `setup-bridge-partner-threshold` command is created correctly and serves its intended purpose. The directory structure for all setup tasks is now consistent.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current Makefile, the
SET_BASE_BRIDGE_PARTNER_THRESHOLD_DIRvariable pointed to the...-pause-bridge-base directory, which resulted in the creation of a folder with an incorrect name when themake setup-bridge-partner-thresholdcommand was executed.Fix: The directory suffix has been changed to
-set-bridge-partner-thresholdso that the makesetup-bridge-partner-thresholdcommand is created correctly and serves its intended purpose.The directory structure for all setup tasks is now consistent.