Clarify use of filters for polling triggers#3710
Open
codesoap wants to merge 1 commit intobigskysoftware:masterfrom
Open
Clarify use of filters for polling triggers#3710codesoap wants to merge 1 commit intobigskysoftware:masterfrom
codesoap wants to merge 1 commit intobigskysoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found the documentation for filters on polling triggers with
hx-trigger="every 1s [...]"less useful than it could be. I initially did not understand, that a filter could be any JavaScript expression. I have clarified this and changed the example to a common scenario: The polling is paused when a tab is in the background.Testing
I have created some test HTML with this body:
I could see in the developer console, that requests were triggered, when the tab was being viewed, but not when I was looking at another tab.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded