Import ssl standard library module directly#3640
Open
chrisnovakovic wants to merge 1 commit intoboto:developfrom
Open
Import ssl standard library module directly#3640chrisnovakovic wants to merge 1 commit intoboto:developfrom
ssl standard library module directly#3640chrisnovakovic wants to merge 1 commit intoboto:developfrom
Conversation
`botocore.httpsession` imports `ssl` from `urllib3.util.ssl_`, which is simply a reference to the `ssl` module from the Python standard library: ``` Python 3.10.12 (main, Jan 26 2026, 14:55:28) [GCC 11.4.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from urllib3.util.ssl_ import ssl >>> ssl <module 'ssl' from '/usr/lib/python3.10/ssl.py'> ``` Avoid the extra degree of indirection by just importing `ssl` from the standard library in `botocore.httpsession`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
botocore.httpsessionimportssslfromurllib3.util.ssl_, which is simply a reference to thesslmodule from the Python standard library:Avoid the extra degree of indirection by just importing
sslfrom the standard library inbotocore.httpsession.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.