Fix UTF-8 character encoding in playlist HTML export#1337
Open
captbaritone wants to merge 1 commit intomasterfrom
Open
Fix UTF-8 character encoding in playlist HTML export#1337captbaritone wants to merge 1 commit intomasterfrom
captbaritone wants to merge 1 commit intomasterfrom
Conversation
- Fix getAsDataURI to properly encode UTF-8 characters before base64 conversion - Add React import required for JSX - Add comprehensive unit tests for playlistHtml including non-Latin-1 characters - Test coverage includes emoji, Chinese, and Cyrillic characters The previous implementation used window.btoa() directly which only supports Latin-1 (ISO-8859-1) characters. This caused InvalidCharacterError when playlist track names contained UTF-8 characters like emoji or non-Latin scripts. The fix encodes UTF-8 strings to percent-encoded format first, then converts to Latin-1 bytes before base64 encoding, ensuring all Unicode characters are properly preserved.
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
| Size Change: 0 B 🆕 Total Size: 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://webamp.sentry.io/issues/7110639842/?project=146021&referrer=slack#exception