Skip to content

[fix] resolve env placeholders in post-processor binary validation#9

Merged
wtorsi merged 1 commit intomainfrom
8.0
Mar 22, 2026
Merged

[fix] resolve env placeholders in post-processor binary validation#9
wtorsi merged 1 commit intomainfrom
8.0

Conversation

@wtorsi
Copy link
Copy Markdown
Contributor

@wtorsi wtorsi commented Mar 22, 2026

Summary

  • validatePostProcessorBinaries() called is_executable() on raw config values, which at compile time are Symfony env placeholder UUIDs (not actual paths)
  • Now uses ContainerBuilder::resolveEnvPlaceholders() to detect env references and resolves them from $_ENV/$_SERVER/getenv() before validating
  • Skips validation gracefully when the env var is not available at compile time (runtime-only resolution)

Test plan

  • 6 new unit tests in ChamberOrchestraImageExtensionTest covering:
    • Env placeholder resolves to executable binary — passes
    • Env placeholder resolves to non-executable — throws
    • Env var not set at compile time — skips validation
    • Literal executable path — passes
    • Literal non-executable path — throws
    • Unused post-processor binary — skips validation
  • Full test suite passes (347 tests, 675 assertions)
  • Code style clean (php-cs-fixer dry-run: 0 issues)

🤖 Generated with Claude Code

validatePostProcessorBinaries() called is_executable() on raw config values which are Symfony env placeholder UUIDs at compile time. Now uses ContainerBuilder::resolveEnvPlaceholders() to detect env references and resolves them from $_ENV/$_SERVER/getenv() before validating. Skips validation when the env var is not available at compile time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wtorsi wtorsi merged commit 949075c into main Mar 22, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant