Skip to content

Conversation

@simonepri
Copy link

The check task, which is run by Travis, needs to depend on jacocoTestReport.

The check task, which is run by Travis, needs to depend on jacocoTestReport.
@codecov
Copy link

codecov bot commented Jun 13, 2017

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #5 +/- ## ====================================== Coverage 50% 50% - Complexity 0 2 +2  ====================================== Files 1 1 Lines 4 4 Branches 1 0 -1 ====================================== Hits 2 2 Misses 1 1 Partials 1 1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7800fe...d2465e4. Read the comment docs.

@stevepeak stevepeak merged commit 2fafb94 into codecov:master Jun 16, 2017
@simonepri
Copy link
Author

simonepri commented Jun 16, 2017

@stevepeak can you verify if this change can affect cicleci example??
Should this line be removed??
https://github.com/codecov/example-gradle/blob/master/circle.yml#L3

I mean, by adding:
check.dependsOn jacocoTestReport
we are saying that when check command is performed, jacocoTestReport is performed also.

So now the circleci example executes jacocoTestReport 2 times.
Am I wrong??

@simonepri simonepri deleted the patch-1 branch June 16, 2017 08:00
@simonepri
Copy link
Author

Also the readme should be updated.
Let me know about.

@simonepri
Copy link
Author

Otherwise another solution could be to add it to .travis.yml and remove the dependsOn from gradle.build

See an exemple:
https://github.com/ottlinger/fotocollector/blob/master/.travis.yml#L16-L18

Let me know which solution seems more cleaner to you.

@simonepri
Copy link
Author

@stevepeak any news about that?

@stevepeak
Copy link
Contributor

Hey, I've very open to pull requests to update our docs. I'm not personally familiar with Gradle, so it's hard for me to review and comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants