Skip to content

refactor: move ApiServer&ApiHandler to cpp file and overwrite config …#396

Merged
BigVan merged 1 commit intocontainerd:dev/snapshotfrom
chenbxun:main
Mar 17, 2026
Merged

refactor: move ApiServer&ApiHandler to cpp file and overwrite config …#396
BigVan merged 1 commit intocontainerd:dev/snapshotfrom
chenbxun:main

Conversation

@chenbxun
Copy link

…after creating snapshot per review

What this PR does / why we need it:
Make the following adjustment according to the code review:

  • move the definition of ApiServer and ApiHandler from api_server.h to api_server.cpp
  • overwrite the config file in use when creating snapshot in case the old one is used again after the process restarts
  • use safe_delete instead of delete

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?
…after creating snapshot per review Signed-off-by: Xun Chen <xunchen@hust.edu.cn>
@BigVan BigVan merged commit ed3355e into containerd:dev/snapshot Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants