Support forwarding of '/var/run/docker.sock' on macOS#1361
Open
Cyberax wants to merge 1 commit intocontainers:mainfrom
Open
Support forwarding of '/var/run/docker.sock' on macOS#1361Cyberax wants to merge 1 commit intocontainers:mainfrom
Cyberax wants to merge 1 commit intocontainers:mainfrom
Conversation
Cyberax force-pushed the main branch 3 times, most recently from 60d4b9a to ed3f569 Compare Podman Desktop doesn't support forwarding of sockets on macOS, but with this hack we can work around it. This also brings podman-compose to parity with the regular command line. Signed-off-by: Aleksei Besogonov <b@alex.net>
Contributor Author
| Is it possible to merge this patch? It's limited in scope and should not affect other OSes. |
Collaborator
| There's another PR fixing the same problem: #1291. Why wouldn't that approach work? |
Contributor Author
| It's essentially the same approach. My PR just adds a more detailed comment about this behavior and makes it conditional for macOS. So merging either PR is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podman Desktop doesn't support forwarding of sockets on macOS, but with this hack we can work around it. This also brings podman-compose to parity with the regular command line.
This PR does not improve compatibility with the spec, but it improves the compatibility with raw Podman on macOS. The current behavior of Podman results in this invocation working fine:
However, podman-compose normalizes the socket paths, so that the equivalent Compose file doesn't work.
The change has an integration test for the macOS desktop.