Improve error message for missing variables in ${VAR?err} syntax#1371
Open
philippedev101 wants to merge 1 commit intocontainers:mainfrom
Open
Improve error message for missing variables in ${VAR?err} syntax#1371philippedev101 wants to merge 1 commit intocontainers:mainfrom
${VAR?err} syntax#1371philippedev101 wants to merge 1 commit intocontainers:mainfrom
Conversation
p12tic requested changes Feb 22, 2026
Collaborator
p12tic left a comment
p12tic left a comment There was a problem hiding this comment.
Looks good. Please add Signed-off-by line to commit message as indicated by failing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Bash-style variable substitution with error enforcement (e.g.,
${MY_VAR?Variable not set}),podman-composeraises aRuntimeErrorif the variable is missing.Currently, this error only contains the custom error text provided in the string (e.g.,
"Variable not set"). It does not indicate which variable triggered the error. In largedocker-compose.ymlfiles with many required variables, this makes debugging impossible without modifying the source code.This PR updates the
RuntimeErrorto prepend the variable name to the error message.RuntimeError: Variable not setRuntimeError: Variable 'OPENSEARCH_ADMIN_PASSWORD': Variable not set