Fix: rescue StandardError instead of Exception in PublishPostJob#61
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Fix: rescue StandardError instead of Exception in PublishPostJob#61bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
Rescuing Exception catches SystemExit, Interrupt, SignalException, and other critical errors that should not be caught. StandardError is the correct base class for rescuing application-level errors. Closes #24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where
rescue Exceptionwas used instead ofrescue StandardErrorinPublishPostJob.Problem
Rescuing
Exceptioncatches critical errors that should not be caught:SystemExit- prevents graceful shutdownInterrupt(Ctrl+C) - prevents manual interruptionSignalException- blocks system signalsNoMemoryError,ScriptError, etc.Solution
Changed to
rescue StandardError => e, which catches application-level errors (network failures, timeouts, etc.) while allowing critical system errors to propagate.Closes #24