Windows: Use MEM_RESERVE for Protection::None allocations#34
Open
Mrmaxmeier wants to merge 1 commit intodarfink:masterfrom
Open
Windows: Use MEM_RESERVE for Protection::None allocations#34Mrmaxmeier wants to merge 1 commit intodarfink:masterfrom
Mrmaxmeier wants to merge 1 commit intodarfink:masterfrom
Conversation
This allows us to reserve virtual memory without commiting as tested in the `alloc_can_reserve_large_parts_of_address_space` test. It seems like there's no downside to this approach for Protection::None allocations, though I've only got a superficial understanding of the Windows virtual memory system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to reserve virtual memory without committing as tested in the
alloc_can_reserve_large_parts_of_address_spacetest. It seems like there's no downside to this approach for Protection::None allocations, though I've only got a superficial understanding of the Windows virtual memory system.FWIW I ran into this here: bytecodealliance/wasmtime#10512