Update windows-sys to ">= 0.52, <= 0.61", fix warnings on recent Rust.#38
Open
ColinFinck wants to merge 1 commit intodarfink:masterfrom
Open
Update windows-sys to ">= 0.52, <= 0.61", fix warnings on recent Rust.#38ColinFinck wants to merge 1 commit intodarfink:masterfrom
windows-sys to ">= 0.52, <= 0.61", fix warnings on recent Rust.#38ColinFinck wants to merge 1 commit intodarfink:masterfrom
Conversation
Author
| Bump CC @darfink |
Author
| Ping @darfink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-sys0.61.x is very important for me, because it consistently usesraw-dylibfor importing APIs from Windows DLLs. This makes a huge difference when using non-MSVC toolchains to build Windows binaries, e.g.x86_64-pc-windows-gnullvm.This syntax is recommended by Microsoft in https://crates.io/crates/windows-sys/0.61.2.
It helps to eradicate duplicate
windows-sysdependencies from the dependency tree of a complex project.Recent Rust also warns about the previous
static mut. However, that one is no longer necessary, because we haveOnceLocknow. I adapted the code accordingly.cargo testdidn't want to run without#[allow(invalid_reference_casting)].CC @darfink