CNDB-12716: Metric for writes blocked on memory allocation#2279
Open
MSpryszynski wants to merge 1 commit intomainfrom
Open
CNDB-12716: Metric for writes blocked on memory allocation#2279MSpryszynski wants to merge 1 commit intomainfrom
MSpryszynski wants to merge 1 commit intomainfrom
Conversation
* Added counter metric for writes blocked on allocation to be able to see spikes of blocked allocations immediately
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-2279 rejected by Butler5 regressions found Found 5 new test failures
Found 4 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the issue
We should know whenever writes get blocked due to memory shortage in the memtable.
CC already has a Timer metric, MemtablePool::blockedOnAllocating. However, the problem with a Timer metric is that it is only updated once the timed event ends. I.e. when the writes are unblocked.
What does this PR fix and why was it fixed
Added counter metric for writes blocked on allocation to be able to see spikes of blocked allocations immediately