Support relative resolved paths and uri-style assets#34
Open
pshinners-blz wants to merge 2 commits intodreamworksanimation:python3from
Open
Support relative resolved paths and uri-style assets#34pshinners-blz wants to merge 2 commits intodreamworksanimation:python3from
pshinners-blz wants to merge 2 commits intodreamworksanimation:python3from
Conversation
Collaborator
| Could you sign the contributor agreement and email that to usdmanager@dreamworks.com? Your contribution is very much appreciated! |
This updates the regular expression usdmanager uses to identify file references. Previously it did not recognize uri style paths, which are supported by Usd under ArResolver2.0. Signed-off-by: Peter Shinners <pshinners@blizzard.com>
This updates the ArResolver2.0 code path to use the source file as an anchor. This allows relative references to work with non-filename asset references. Usd Manager has some internal path manipulation to allow relative paths to work with plain file paths, but it needs to use the resolver plugin for non file paths. This logic already exists when dealing with the ArResolver1.0 API, but when the 2.0 i support was added this was overlooked. Signed-off-by: Peter Shinners <pshinners@blizzard.com>
pshinners-blz force-pushed the ar2-fixes branch from 765f342 to 1d2b6ba Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit updates the regular expression usdmanager uses to identify references. Previously it did not recognize uri style paths, which are supported by under ArResolver2.0.
The second commit updates the ArResolver2.0 code path to use the source as an anchor. This allows relative references to work
with non-filename asset references. Usd Manager has some internal path manipulation to allow relative paths to work with plain file paths, but it needs to use the resolver plugin for non file paths. This logic already exists when dealing with the ArResolver1.0 API, but when the 2.0 support was added this was overlooked.