feat: add git commit SHA metadata to all Nomad jobs#1993
Draft
joe-lombrozo-s-bot[bot] wants to merge 6 commits intomainfrom
Draft
feat: add git commit SHA metadata to all Nomad jobs#1993joe-lombrozo-s-bot[bot] wants to merge 6 commits intomainfrom
joe-lombrozo-s-bot[bot] wants to merge 6 commits intomainfrom
Conversation
This change adds the git_commit_sha as metadata to all Nomad jobs deployed via Terraform. The commit SHA is passed from GitHub Actions workflows through Terraform variables down to the Nomad job specifications. Changes: - Updated deploy-infra.yml and deploy-job.yml workflows to export GIT_COMMIT_SHA - Added git_commit_sha to Makefile tf_vars - Added git_commit_sha variable to provider-gcp and nomad module variables - Added meta block with git_commit_sha to all Nomad job HCL files - Updated all module calls to pass git_commit_sha through This enables tracking which git commit is currently deployed for each Nomad job.
joe-lombrozo-s-bot bot requested review from ValentaTomas, dobrac and jakubno as code owners ![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca7d58e982
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Make git_commit_sha required in all job modules to catch missing pass-throughs at plan time. The root provider-gcp/variables.tf still has a default for when the env var isn't set during local development.
Uses `git rev-parse --short HEAD` as the default value for GIT_COMMIT_SHA if not explicitly set via environment variable. Falls back to 'unknown' if not in a git repository.
dobrac approved these changes Feb 26, 2026
| -include ${ENV_FILE} | ||
| | ||
| # Default to current git commit SHA if not set via environment | ||
| GIT_COMMIT_SHA ?= $(shell git rev-parse --short HEAD 2>/dev/null || echo "unknown") |
Contributor
There was a problem hiding this comment.
wouldn't this be annoying for dev where you rebuild just one job, but then run make plan ; make apply?
Member
There was a problem hiding this comment.
would it be possible to set up terraform to ignore_changes for this somehow?
Instead of adding git_commit_sha to every Nomad job's meta block (which would cause job re-registration on every commit), store the deployment commit SHA in a Nomad Variable at deployments/metadata. This avoids unnecessary job version bumps and batch job re-runs while still making the commit SHA available for debugging and audit via the Nomad Variables API/UI. Jobs can optionally read the SHA at runtime using: {{ with nomadVar "deployments/metadata" }}{{ .git_commit_sha }}{{ end }} This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the git_commit_sha as metadata to all Nomad jobs deployed via Terraform. The commit SHA is passed from GitHub Actions workflows through Terraform variables down to the Nomad job specifications.
Changes
deploy-infra.ymlanddeploy-job.ymlworkflows to exportGIT_COMMIT_SHAgit_commit_shato Makefiletf_varsgit_commit_shavariable to provider-gcp and nomad module variablesgit_commit_shato all Nomad job HCL filesgit_commit_shathroughBenefits
This enables tracking which git commit is currently deployed for each Nomad job, which helps with:
Testing