Actions: Refresh symbolic window actions#1295
Open
wpkelso wants to merge 13 commits intoelementary:mainfrom
Open
Actions: Refresh symbolic window actions#1295wpkelso wants to merge 13 commits intoelementary:mainfrom
wpkelso wants to merge 13 commits intoelementary:mainfrom
Conversation
wpkelso changed the title wpkelso changed the title 
danirabbit requested changes Sep 10, 2024
Member
danirabbit left a comment
danirabbit left a comment There was a problem hiding this comment.
I think this makes the close button too big. Especially apparent here:
Seems way larger than the plus icon
Member Author
| Slightly decreased the size of the arms to find a middle-ground between the two sizes, though I think it may have caused some pixel-fitting issues :( Extra reference of what size is currently like on main, for the sake of it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #928 by unifying the size and language of the window controls.
Previously,
window-closeused a baseline of 4px,window-minimizeused a border of 3px, andwindow-maximize/window-restoreboth used 4px borders. This mostly unifies to 2px border, withwindow-closenow using a 3px border because 2px felt slightly large in comparison to the othersAdditionally,
window-minimizeused an older shape language and color, so that has been unified as well.In context:
