ask xcrun(1) for the sourcekit-lsp server path #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Recent XCode ships with the `sourcekit-lsp` server, but it is a "developer tool" and so not on the normal path. This updates the logic for discovering the executable to: 1. use a `lsp-dependency` to specify the executable, and 2. try `xcrun --find` if the executable is not on the path. This makes the platform-supplied server work for me, and is generally how apple treat these development tools. Additionally, the server is registered with `lsp-mode` automatically, through an autoload, so the package will just work™ after installation.
Collaborator
| Thanks for your contribution! |
| Hello! @danielmartin @slippycheeze this commit broke my setup so I had to revert it, here is my configuration if that helps: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Recent XCode ships with the
sourcekit-lspserver, but it is a "developer tool"and so not on the normal path.
This updates the logic for discovering the executable to:
lsp-dependencyto specify the executable, andxcrun --findif the executable is not on the path.This makes the platform-supplied server work for me, and
is generally how apple treat these development tools.
Additionally, the server is registered with
lsp-modeautomatically, through an autoload, so the package will
just work™ after installation.