Skip to content

Deprecate Non Strict Relationships#2093

Open
MichalBryxi wants to merge 2 commits intoember-learn:masterfrom
MichalBryxi:mb/1988-explicit-async-and-inverse
Open

Deprecate Non Strict Relationships#2093
MichalBryxi wants to merge 2 commits intoember-learn:masterfrom
MichalBryxi:mb/1988-explicit-async-and-inverse

Conversation

@MichalBryxi
Copy link
Copy Markdown
Contributor

@MichalBryxi MichalBryxi commented Feb 4, 2025 •
edited
Loading

TODO

  • Can someone check that I set inverse correctly (author blindness, can't guarantee)?
  • There was originally [this async: false], which I believe was incorrect. The JSON-API payload is using only IDs, so I would expect it to be async: true. Can someone confirm / deny?
  • All comments are resolved
  • Once the two above are checked, I can copy&paste the solution to all versions >= v5.0
@MichalBryxi
fix: v5.0 ember-data deprecates non-strict relationships
fc4db08 
- As per [ember-data:deprecate-non-strict-relationships](https://deprecations.emberjs.com/ember-data/v4.x/#toc_ember-data-deprecate-non-strict-relationships) we should update the guides to list all relationships explicitly. - Supports ember-learn#1988
@MichalBryxi
fix: { async: true } -> { async: false } for v5.0 ember-data
cb6e8b7 
- Seems like we want most of the examples to be synchronous - Supports: ember-learn#1988
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 4, 2025 •
edited
Loading

✅ Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit cb6e8b7
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/67a1bb1ec8e16800084cd739
😎 Deploy Preview https://deploy-preview-2093--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@MichalBryxi @wozny1989