Expand 'Extending the meaning of settled()' with test waiter guidance#2203
Open
gitKrystan wants to merge 1 commit intoember-learn:masterfrom
Open
Expand 'Extending the meaning of settled()' with test waiter guidance#2203gitKrystan wants to merge 1 commit intoember-learn:masterfrom
gitKrystan wants to merge 1 commit intoember-learn:masterfrom
Conversation
The existing section was a brief paragraph pointing to the @ember/test-waiters readme. This expands it with practical guidance on why test waiters matter, which async patterns need them, how to recognize missing waiters, and how test isolation validation helps catch these issues early.
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The existing section is a single paragraph pointing to the @ember/test-waiters readme. In practice, many Ember developers struggle with flaky tests caused by missing test waiters, and having this guidance in the official guides makes it more discoverable.