feat: add fontless to use custom fonts#1037
Open
mohammedzamakhan wants to merge 3 commits intoepicweb-dev:mainfrom
Open
feat: add fontless to use custom fonts#1037mohammedzamakhan wants to merge 3 commits intoepicweb-dev:mainfrom
mohammedzamakhan wants to merge 3 commits intoepicweb-dev:mainfrom
Conversation
Comment on lines +83 to +86
| app.use( | ||
| '/_fonts', | ||
| express.static('build/client/_fonts', { immutable: true, maxAge: '1y' }), | ||
| ) |
Contributor Author
There was a problem hiding this comment.
Not happy about these lines, which I had to add for making it work in dev mode.
kentcdodds reviewed Sep 1, 2025
Member
kentcdodds left a comment
There was a problem hiding this comment.
This is great! Could you also update the documentation on fonts?
Comment on lines +83 to +86
| app.use( | ||
| '/_fonts', | ||
| express.static('build/client/_fonts', { immutable: true, maxAge: '1y' }), | ||
| ) |
Contributor Author
| @kentcdodds docs updated! |
9d8d843 to 46aa828 Compare 46aa828 to 889d124 Compare Member
| I was about ready to merge this and then I noticed when I started the dev server we get a bunch of warnings from MSW I would like you to clean up: Two things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw this blog post about fontless here https://qwik.dev/blog/fontless/, and got interested it to get in the epic-stack.
Test Plan
Checklist
Screenshots