Open
Conversation
dedeswim requested changes Mar 26, 2026
Member
dedeswim left a comment
dedeswim left a comment There was a problem hiding this comment.
Thank you so much! Please see my comment
| raise ASTParsingError(f"The keyword arguments should be strings. Got {keyword.arg}") | ||
| args[keyword.arg] = parse_arg_value(keyword.value) | ||
| arg = parse_arg_value(keyword.value) | ||
| args[keyword.arg] = "..." if arg == Ellipsis else arg |
Member
There was a problem hiding this comment.
Why would the model call the tool with ...? Could you please add a comment that explains this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs that caused AgentDojo to consistently crash (when running with Ollama + Llama 4) and adds unit tests to ensure the bugs remain fixed.