Skip to content

fix(regions): bump deprecated version threshold to v2.2.0#330

Open
flemzord wants to merge 1 commit intomainfrom
fix/regions-deprecated-version-threshold
Open

fix(regions): bump deprecated version threshold to v2.2.0#330
flemzord wants to merge 1 commit intomainfrom
fix/regions-deprecated-version-threshold

Conversation

@flemzord
Copy link
Member

Summary

  • Bump the semver threshold for the formance.com/deprecated annotation from v2.0.0 to v2.2.0 in the Versions CRD template
  • Versions below v2.2.0 are now marked as deprecated
  • Chart version bumped to 3.8.2

Test plan

  • just pc passes (lint, schema generation, template rendering)
@flemzord flemzord requested a review from a team as a code owner March 17, 2026 14:50
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1501a2cd-3f4d-48ad-a0a7-e2301e5e1a85

📥 Commits

Reviewing files that changed from the base of the PR and between 8115ccc and 95594cd.

⛔ Files ignored due to path filters (3)
  • charts/formance/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/regions/Chart.yaml is excluded by !**/*.yaml
  • charts/regions/templates/versions.yaml is excluded by !**/*.yaml
📒 Files selected for processing (2)
  • README.md
  • charts/regions/README.md

Walkthrough

Two README files have their Regions chart version badge updated from 3.8.1 to 3.8.2. The changes are purely version number increments with no modifications to other content or structure.

Changes

Cohort / File(s) Summary
Version Badge Updates
README.md, charts/regions/README.md
Regions chart version badge bumped from 3.8.1 to 3.8.2 in both files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

release

Suggested reviewers

  • gfyrag

Poem

🐰 A little hop, a version's gleam,
From 3.8.1 to 3.8.2, it seems!
In README's rows, the numbers dance,
A release milestone—give it a chance! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping a deprecated version threshold, but the raw summary shows only version number updates in README files with no changes to CRD templates or deprecation logic. Verify that the changes actually include updates to the Versions CRD template's formance.com/deprecated annotation threshold, or update the title to accurately reflect the version bumps in README files.
Description check ❓ Inconclusive The description describes bumping a semver threshold in a Versions CRD template and updating chart version, which aligns with the PR objectives but contradicts the raw summary showing only README version updates. Clarify whether the changeset includes modifications to the Versions CRD template or if the changes are limited to README version bumps, as the description and raw summary appear inconsistent.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/regions-deprecated-version-threshold
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working docs release labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working docs release

1 participant