Conversation
This PR has the enclave runner keep track about all of the usercalls that enclaves do over their lifetimes. This includes: - The total number of each async usercall done - How many of each sync usercall each enclave TCS has done - For `wait`s and `send`s, additional grouping by signal type
jethrogb reviewed Aug 2, 2024
Member
jethrogb left a comment
There was a problem hiding this comment.
Instead of aggregating everything already, wouldn't it be better to have some strace-style logging of every call and then do post-processing later?
Comment on lines +60 to +62
| const USERCALL_QUEUE_SIZE: usize = 32768; | ||
| const RETURN_QUEUE_SIZE: usize = 32768; | ||
| const CANCEL_QUEUE_SIZE: usize = USERCALL_QUEUE_SIZE; |
Member Author
That seems a lot harder, because the application's stdout/stderr is intermingled with the enclave runner's stdout/stderr. Also, the overhead of printing that is non-trivial, and would probably have to be opted into, while this atomic based aggregation is essentially zero-cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the enclave runner keep track about all of the usercalls that enclaves do over their lifetimes. This includes:
waits andsends, additional grouping by signal typeThe intended integration path is for consumers of this library to set up signal handling or some other mechanism to trigger collecting and logging the stats. The included formatting looks like this (from a web server enclave using async usercalls):
This is just an initial pass, I definitely need to add more robust and/or elegant logic related to the absolute number of usercalls and stringifying them.