Added glm.cppm to CXX_MODULES target_sources#1390
Draft
sweet-niamhy wants to merge 6 commits intog-truc:masterfrom
Draft
Added glm.cppm to CXX_MODULES target_sources#1390sweet-niamhy wants to merge 6 commits intog-truc:masterfrom
sweet-niamhy wants to merge 6 commits intog-truc:masterfrom
Conversation
| Wouldn't an intermediate target work for both glm and glm-header-only ? add_library(glm-miu STATIC) target_sources(glm-miu PUBLIC FILE_SET CXX_MODULES BASE_DIRS . FILES glm.cppm ) target_link_libraries(glm-header-only INTERFACE glm-miu) |
Author
I tested this out and it works with |
Author
| I might need to work on this a while as I'm seeing some issues with different options enabled. I don't have a lot of spare time lately but will try to putter around! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has been mentioned in an issue #1372 and in the comment #1208 (comment) so this would enable resolving of those issues.