Fix retrieval of remote source logos in GeoNetwork harvesters.#9187
Fix retrieval of remote source logos in GeoNetwork harvesters.#9187josegar74 wants to merge 4 commits intogeonetwork:mainfrom
Conversation
Logo retrieval was assuming that the logos extension was gif only
fxprunayre left a comment
There was a problem hiding this comment.
Looks fine. Can be tested with https://sextant.ifremer.fr/geonetwork/images/logos/b08fe709-1ced-4a07-8edf-06aa6ccdf2e3.gif vs https://sextant.ifremer.fr/geonetwork/images/logos/b08fe709-1ced-4a07-8edf-06aa6ccdf2e3.png
At some point, maybe we should consider adding a dedicated endpoint for source logo retrieval without relying on image extension.
juanluisrp left a comment
There was a problem hiding this comment.
There ia a security issue in this code.
…lative path characters
| @juanluisrp I have added in the harvester code to check that the logo doesn't contain bad path characters. See 4a6ef4b I haven't update |
| @juanluisrp please check the latest commit: 8e53529 |
Logo retrieval was assuming that the logos extension was
gifonly, which is not the case,pngandjpgformats are allowed also.Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation