feat(cloudflare): Support basic WorkerEntrypoint#19884
Open
feat(cloudflare): Support basic WorkerEntrypoint#19884
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
JPeer264 force-pushed the jp/cf-workers-entrypoint branch from 3a7024f to f82649e Compare Contributor
size-limit report 📦
|
JPeer264 force-pushed the jp/cf-workers-entrypoint branch from 71b3910 to 1ef2947 Compare ![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
dev-packages/e2e-tests/test-applications/cloudflare-mcp/src/env.d.ts Outdated Show resolved Hide resolved
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #15942
This is a basic instrumentation for
WorkerEntrypoint. There is no extrainstrumentWorkerEntrypointexported, and should work directly withwithSentryOOTB:To support the full
WorkerEntrypointthere is the need to instrument RPC methods. Without that we can't fully supportWorkerEntrypoints but just the basics of it. This can be added once #19991 lands (it is safe to review now and instrument the env in a separate PR)If you look at the instrumentations themselves, there is no
isInstrumentedormarkAsInstrumented. The reason is that on the one hand this is not required, as every request is spawning a new instance of theWorkerEntrypointand on the other hand it wouldn't work as it would mark it as instrumented, but on the request thefetchis overridden and not instrumented.