Draft
Conversation
This module contains a macro to create data structures containing constant names at the same time as the constants are defined. Use this macro to define elf/macho/pe constants, and replace most of the constant names in the readobj example.
Similar for other elf structs. Old names are kept as type aliases. This matches normal ELF naming conventions, and will provide consistency with names for newtypes in future. Non-breaking
SectionKind is format independent, and the Elf variant never belonged there. Fixing this now because adding a newtype for sh_type will also be a breaking change.
This includes the SHF constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of newtypes for some ELF constants, with more to come. Also some related cleanups.
Builds on top of #876. See individual commits.