feat(pool): Allow to optionally include busy runners into the pool#5078
Open
rvem wants to merge 1 commit intogithub-aws-runners:mainfrom
Open
feat(pool): Allow to optionally include busy runners into the pool#5078rvem wants to merge 1 commit intogithub-aws-runners:mainfrom
rvem wants to merge 1 commit intogithub-aws-runners:mainfrom
Conversation
'pool_config' is useful when one wants to ensure that a certain number of runners is running within given time periods. However, when 'pool_config' is used in a combination with persistent runners, the pool lambda tends to spin up new runner instance when it sees that some existing runners are online, but busy. As a result, with frequent pool lambda checks, the total size of the runners pool tends to grow more than desired (without respecting 'runners_maximum_count', which is only considered by the 'scale_up' lambda). These changes introduce a new 'pool_include_busy_runners' module variable to make it possbile to include all online runners (both idle and busy) into the pool, so that the pool's lambda only tops up the pool if not enough runners are online.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
'pool_config' is useful when one wants to ensure that a certain number
of runners is running within given time periods.
However, when 'pool_config' is used in a combination with persistent runners,
the pool lambda tends to spin up new runner instance when it sees that some
existing runners are online, but busy.
As a result, with frequent pool lambda checks, the total size of the runners
pool tends to grow more than desired (without respecting
'runners_maximum_count', which is only considered by the 'scale_up' lambda).
These changes introduce a new 'pool_include_busy_runners' module variable
to make it possbile to include all online runners (both idle and busy)
into the pool, so that the pool's lambda only tops up the pool if not
enough runners are online.
Test Plan
Tested on a module instance with persistent runners, also added a few unit tests to the pool lambda itself.
Related Issues