Doc: Add SSRF security warnings to InternetDomainName validation methods#8293
Open
artahir-dev wants to merge 1 commit intogoogle:masterfrom
Open
Doc: Add SSRF security warnings to InternetDomainName validation methods#8293artahir-dev wants to merge 1 commit intogoogle:masterfrom
artahir-dev wants to merge 1 commit intogoogle:masterfrom
Conversation
Syntactic validation in `InternetDomainName` is insufficient for SSRF prevention, as domains like `169.254.169.254.nip.io` are syntactically valid but resolve to sensitive internal IPs. This commit adds a targeted security warning to `hasPublicSuffix()`, `isUnderPublicSuffix()`, and `isValid()` to caution developers against misusing these methods as SSRF guards and recommends post-resolution IP checks instead. RELNOTES=n/a
Member
Can you show some examples of such usage? |
chaoren added package=net type=api-docs This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit security warnings to the Javadoc of
InternetDomainName.hasPublicSuffix(), isUnderPublicSuffix(), and isValid(String).While InternetDomainName correctly documents at the class level that it only performs syntactic analysis, these specific methods are frequently misused as SSRF prevention controls. As demonstrated by recent CVEs in other frameworks (e.g., CVE-2024-22243), syntactic-only validation is insufficient to block SSRF when using wildcard DNS services like
nip.io(e.g.,169.254.169.254.nip.io).Changes included:
RELNOTES=n/a