overlay: support userxattr mount option for overlays in user namespaces#12797
Open
insanitybit wants to merge 1 commit intogoogle:masterfrom
Open
overlay: support userxattr mount option for overlays in user namespaces#12797insanitybit wants to merge 1 commit intogoogle:masterfrom
insanitybit wants to merge 1 commit intogoogle:masterfrom
Conversation
| Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
a856f4b to 6503808 Compare 6503808 to 58c7112 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm experiencing a sentry panic when I enter a user namespace and then attempt to mount an overlay filesystem. This is fundamentally because gVisor does not support the
userxattrmount option, instead hardcodingtrusted.overlayprefix, leading to a permission mismatch between the init namespace and the user namespace.When an overlay is mounted inside a user namespace, setting these xattrs fails with EPERM, causing the sentry panic:
This PR adds support for the userxattr mount option, which uses user.overlay.* xattrs instead of trusted.overlay.*. This appears to be very similar to the linked kernel commit that implements similar functionality except that the linked kernel commit is careful to disable
redirect_dirandmetacopywhenuserxattris active but that isn't relevant here since gvisor does not support those currently.Relevant kernel commit here, which I think is analagous.
"This is necessary for overlayfs to be able to be mounted in an unprivileged namepsace [sic]."
torvalds/linux@2d2f2d7
Discovered this while trying to set up some internal isolation within gVisor, I had AI produce a repro C file here:
#1636 (comment)
I don't really use Go so I did make use of Claude for this PR, though I tried to be careful in comparing it to the kernel commit.