Nftables: Remove the overheads from register ops.#12800
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Nftables: Remove the overheads from register ops.#12800copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
bc42af4 to da01d2f Compare - Shift register boundary checks from `evaluate` (hot path) to rule `init` (once at setup). - Remove `registerData` interfaces with concrete types to eliminate transient heap allocations and interface overhead in the evaluation hot path. - Fix register store validation to match Linux kernel behavior (net/netfilter/nf_tables_api.c:nft_validate_register_store). Instead of hard-limiting to 4 or 16 bytes, we validate against the 64-byte total array limit. - nft_payload: safeguard signed-unsigned overflow. PiperOrigin-RevId: 888913686
da01d2f to 611ecaf Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nftables: Remove the overheads from register ops.
evaluate(hot path) to rule
init(once at setup).registerDatainterfaces with concrete types toeliminate transient heap allocations and interface overhead
in the evaluation hot path.
(net/netfilter/nf_tables_api.c:nft_validate_register_store).
Instead of hard-limiting to 4 or 16 bytes,
we validate against the 64-byte total array limit.